Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: licenses.info endpoint only available for admins #30644

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: c2bb110

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.5.0 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #30644 (c2bb110) into develop (a0dcc38) will decrease coverage by 0.23%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30644      +/-   ##
===========================================
- Coverage    51.29%   51.07%   -0.23%     
===========================================
  Files          811      805       -6     
  Lines        15059    15077      +18     
  Branches      2751     2787      +36     
===========================================
- Hits          7725     7700      -25     
- Misses        6926     6942      +16     
- Partials       408      435      +27     
Flag Coverage Δ
e2e 48.37% <ø> (-0.20%) ⬇️
unit 64.76% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2023
@rodrigok rodrigok marked this pull request as ready for review October 16, 2023 19:15
@rodrigok rodrigok requested review from a team as code owners October 16, 2023 19:15
@rodrigok
Copy link
Member

QA can be done on #30469

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 16, 2023
@kodiakhq kodiakhq bot merged commit 85ddfb2 into develop Oct 16, 2023
45 checks passed
@kodiakhq kodiakhq bot deleted the fix/licenses-info-permission branch October 16, 2023 21:46
gabriellsh added a commit that referenced this pull request Oct 18, 2023
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: inconsistent behavior when removing subscriptions and inquiries (#30572)
  fix: Handle AWS S3 Re-Authentication via s3.getSignedUrlPromise (#30642)
  test: wait for the name update finish (#30663)
  regression: Restore default limits to community apps (#30611)
  refactor: Move functions out of `Livechat.js` (#30650)
  chore: remove license v3 public key envvar (#30646)
  fix: Read receipts are not created on the first time a user reads a room (#30610)
  fix: licenses.info endpoint only available for admins (#30644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants